Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS style not updated #50

Open
DanielZuwala opened this issue Sep 9, 2015 · 2 comments
Open

CSS style not updated #50

DanielZuwala opened this issue Sep 9, 2015 · 2 comments

Comments

@DanielZuwala
Copy link

Sorry if it's a stupid question but I don't manage to update change in the CSS files.

  • I have made modification on about.less
  • The files are correctly compiled in bundle-blessed1.css
  • I push the modification to my repo
  • I pull the modification on my edx server (full stack production)
  • I update the asset with the command : paver update_assets lms --settings=aws

But I see no change. I know that the theme is correctly installed because changes in template files are effective. So I don't get it.

The _ionisx.scss file is always empty is it ok ?
The change doesn't seem to be in the sass file generated (in my case myurl/static/css/lms-main.d8d16e63defa.css)

I am missing something ?

@tusbar
Copy link
Contributor

tusbar commented Sep 9, 2015

Hey @DanielZuwala,

The _ionisx.scss file is indeed meant to be empty as the theme does not override any Sass from Open edX.

It creates another CSS file from the Less source. That CSS file is included in https://github.com/IONISx/edx-theme/blob/master/templates/theme-head-extra.html.

I believe that you also need to restart the LMS, after running update_assets.

@DanielZuwala
Copy link
Author

Hi, thanks for you answer.

I finally found the issue. I was trying to change the css of the about page of a course, and the changes were not updated. The issue was that the course/main.less is included inside a body.view-incourse selector. But when the about page of a course is loaded, the body tag doesn't have the view-incourse class.

I suppose this behavior might be considered as a bug ? I end up removing the view-incourse selector in the pages/main.less file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants