-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release schema + validator (+doc gen) on PyPi #68
Comments
Lets try to adhere to good CLI practices: https://clig.dev/ Mainly:
|
In case test config is needed: https://github.com/mapping-commons/sssom-py/blob/master/tests/test_config.yaml |
Also, can we make sure we can use these as a library in python directly:
|
pypi package released: https://pypi.org/project/dosdp/0.1.0.dev1/ If ok, we can release a stable version and update usage scenarios at README.md UsageFrom the CLI$ pip3 install dosdp==0.1.0.dev1
$ dosdp -v <test.yaml> From Pythonfrom dosdp import validator
validator.validate("test.yaml") |
Hey @hkir-dev! Great push forward; I would like to request one change. I am trying to coordinate a standardisation of parameter across all the tools we are involved in. I will share the full list with you when it is finalised. But generally I would like to always use the same grammar:
So in this case:
or in the case of documentation
What do you think? Sorry to spring this on you after the pypi release, I was not paying enough attention :) |
It's clearly flagged as a dev & pre-release on PypI, so I think no expectation of stability yet Note - Setup.py should be commited at root and should include link to doc |
Potentially relevant: Can use GitHub actions to standardise build and link to release. e.g. see |
Cli interface updated. All code is in branch pypi_release UsageFrom the CLI$ pip3 install dosdp==0.1.0.dev1
$ dosdp validate -i <test.yaml>
$ dosdp document -i <schema.yaml> -o <schema.md> From Pythonfrom dosdp import validator
validator.validate("test.yaml") |
Awesome! Thanks! The document command will have to do something more than just documenting the schema, but we can discuss this next week. Thanks! |
Package release github action added. |
New python package released
UsageFrom the CLI$ dosdp validate -i <test.yaml or 'test folder'>
$ dosdp document --schema
$ dosdp document --schema -o <schema.md>
$ dosdp document -i <pattern.yaml> -o <pattern.md> From Pythonfrom dosdp import validator
validator.validate("test.yaml") |
Awesome! This is super cool, agree! One thing missing:
So that this overview table of all yamls in a folder and the overview is created |
Update implemented. If input is a folder, an "overview.md" file is generated in the output folder along with the pattern documentations. |
Given the document -i, how is the data preview created? shouldn't there be a link to a data directory as well? |
Final repo cleanup. Move lib, patterns, spec & any stray unused files -> attic. |
@matentzn inorder to make pattern documentation interface compatible with the previous schema documentation interface, I had removed the sample data parameter. Now I added that sample data parameter back and made a new relase https://test.pypi.org/project/dosdp/0.1.7.dev1/ UsageFrom the CLI$ dosdp validate -i <test.yaml or 'test folder'>
$ dosdp document --schema
$ dosdp document --schema -o <schema.md>
$ dosdp document -i <pattern.yaml or pattern folder> -o <pattern.md or output folder>
$ dosdp document -i <pattern.yaml or pattern folder> -d <sample data folder> -o <pattern.md or pattern folder> From Pythonfrom dosdp import validator
validator.validate("test.yaml") |
Awesome, thank you! I will have to integrate this at some point into ODK, when I make a larger push on pattern infrastructure. |
structure
The text was updated successfully, but these errors were encountered: