Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's a typo in use case sec pic #71

Open
maggielovedd opened this issue Dec 11, 2020 · 2 comments
Open

There's a typo in use case sec pic #71

maggielovedd opened this issue Dec 11, 2020 · 2 comments

Comments

@maggielovedd
Copy link

Thank you for this code. The typo is a bit confusing, I suppose the sec pic in use case should be eye-in-hand

@marcoesposito1988
Copy link
Collaborator

Yes, that's right. However, this typo is already in the launch files, and I didn't find a way change that without breaking compatibility for existing users. If I fix the documentation without changing the launch files, there would be an inconsistency, which would bring probably even more confusion than the typo.

If you have a suggestion for a migration path that doesn't disturb existing users, that's more than welcome. Otherwise I will fix that in the ROS2 version directly 😅

@marcoesposito1988
Copy link
Collaborator

Oh, actually the documentation is already inconsistent. Well, I'll take a better look when I find the time. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants