Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nick/updating create task view #93

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nickKearns
Copy link

@nickKearns nickKearns commented Mar 2, 2021

Description

The entire Task Detail View UI is now done programmatically.
When testing previous version on an iPhone XS the date picker was barely visible on the bottom of the screen now it has a larger frame so it can be tapped on easier.
The feature to add an image to the task has been removed in this change but I plan on adding it back in a future PR.

Type of Change:

  • All outlets are now programmatic UI elements
  • All IBActions are now objc action functions
  • UIDatePicker has an updated frame for better viewing
  • All constraints are programmatic using NSLayoutConstraints
  • Changed the custom collection view cell to programmatic UI

How Has This Been Tested?

Tested on an iPhone XS and compared to the previous storyboard version

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • [] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)

@aaryankotharii
Copy link
Member

Hi there @nickKearns, thank you for your interest in solving this issue. Your solution looks good to me!
Please fix the merge conflict post which we can merge this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants