Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task status feature added (mark as done)) #42

Closed
wants to merge 1 commit into from

Conversation

gitanshwadhwa28
Copy link

You can keep the task and mark as done if completed instead of just deleting it ( feature in many to do applications)

Description

Include a summary of the change and relevant motivation/context. List any dependencies that are required for this change.

Fixes #38

Type of Change:

  • Code
  • Addition of new feature
  • User Interface

Simulator Screen Shot - iPhone 11 Pro Max - 2020-10-04 at 01 30 01

You can keep the task and mark as done if completed instead of just deleting it ( feature in many to do applications)
@tejuamirthi
Copy link
Contributor

Hey @aaryankotharii are we proceeding with this ui?

I feel it'd be better to have different sections and display the completed tasks into that sections. In that way, we can have other possibility of having tabs below/above the search bar for different status. Like completed, overdue and inprogress or anything other we can decide.

My point is it'd be better and to plan with what's next in mind and make it future proof if we can. I'll place my bet on writing a logic that need not be edited later on. If we could seperate out the sections now in logic, when in the future, the tabs would only require a UI change and not the logic. I hope you got the point. Would love to hear your views! You obviously could suggest a better outcome entirely.

Also @gitanshwadhwa28 good work! Keep it up. Should have shared earlier if you are contributing. Anyways glad you have contributed. Let me know what you think about the above.

@aaryankotharii
Copy link
Member

Hi @gitanshwadhwa28 , Thank you for your interest in working on this issue. The issue you have linked this pr to does not quite solve the issue's purpose but your idea of marking a task as done is great! That said, from a ux perspective, done should be more accessible than sliding a task and then selecting done. Hence you will see a checkmark box in most to-do applications. We can also do something on the same terms.

How to proceed further?

  • remove the done action from the sliding context menu.
  • simply add a button in tableview cell to mark a task as done.

since all your functions are quite atomic we don't need to make any changes apart from the 2 mentioned above.

example preview :
Screenshot 2020-10-05 at 6 45 45 PM

Copy link
Member

@aaryankotharii aaryankotharii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request a review once done :)

@aaryankotharii
Copy link
Member

Hi @gitanshwadhwa28, since this issue has been solved in #61 , I will be closing this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

status for tasks
3 participants