Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human-readable results output #8

Open
pscicluna opened this issue Oct 18, 2022 · 2 comments
Open

Human-readable results output #8

pscicluna opened this issue Oct 18, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@pscicluna
Copy link
Collaborator

pgmuvi should create an output table so that people can understand what the results are and what they mean.

This might involve two separate implementations for MAP and MCMC solutions, as credible intervals need to be reported in the latter case.

@pscicluna pscicluna added the enhancement New feature or request label Oct 18, 2022
pscicluna added a commit that referenced this issue Oct 21, 2022
Looks good, merge is partial solution to #8
@pscicluna
Copy link
Collaborator Author

Partial solution for 1D lightcurves in #22

@pscicluna
Copy link
Collaborator Author

pscicluna commented Dec 13, 2022

Testing on a 2D lightcurve results in the following error:

Traceback (most recent call last):
  File "/home/psciclun/Downloads/light curves-20221213T145300Z-001/light curves/pgmuvi2Dtest.py", line 42, in <module>
    lightcurve_2d.print_results()
  File "/home/psciclun/code/pythondev/pgmuvi/pgmuvi/lightcurve.py", line 395, in print_results
    print(f"{key}: {results_tmp[:,0].flatten()}, {results_tmp[:,1].flatten()}")
IndexError: index 1 is out of bounds for axis 1 with size 1 

We will have to figure out what shape the results are in for each variable in 2D. It did successfully output the loss, delta loss, likelihood.noise_covar.raw_noise, mean_module.constant, and covar_module.raw_mixture_weights, which as expected are all 1D. It couldn't output the mixture means or scales.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant