Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Lightcurve to a subclass of torch.nn.Module? #28

Open
pscicluna opened this issue Aug 20, 2023 · 1 comment
Open

Convert Lightcurve to a subclass of torch.nn.Module? #28

pscicluna opened this issue Aug 20, 2023 · 1 comment
Assignees

Comments

@pscicluna
Copy link
Collaborator

Right now Lightcurve is a regular class. I think if it were converted to a Module, we could leverage more of torch's useful features and simplify the structure of the class a bit.

@pscicluna
Copy link
Collaborator Author

This looks like a good idea to make sure that GPU computing works more smoothly. both Lightcurve and Transformer need to be converted, and all their tensor attributes should be created with self.register_buffer(...)

@pscicluna pscicluna self-assigned this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant