Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on comment notifications scrolls to that comment #598

Open
tibetsprague opened this issue Nov 2, 2022 · 4 comments · May be fixed by #653
Open

Clicking on comment notifications scrolls to that comment #598

tibetsprague opened this issue Nov 2, 2022 · 4 comments · May be fixed by #653
Assignees

Comments

@tibetsprague
Copy link
Contributor

tibetsprague commented Nov 2, 2022

The comment should flash or be highlighted.

@lorenjohnson
Copy link
Member

Note to self: A bit differently than was implemented on Web, I think in the App I'll show only the Post and the Comment linked to (as well as it's parent comment if there is one), and reply upon the pagination information to generate the "X more comments" links surrounding those entries. We'll see once I get into implementing if what I have available on our API makes this actually simpler, but I think it will. This is what Facebook does in these cases.

@lorenjohnson
Copy link
Member

@thomasgwatson My above note to self is now a note to you. I think for a better UX the above implementation suggestion would be better. Just load the post and to single comment utilising the existing functionality for "X more comments" links above and below the comment displayed. Last I checked this is what Facebook was doing on both Web and their App, but who knows if they aren't doing something different by now. Either way, I think doing it that way will get snappy and keep us out of trouble on long comment threads.

@thomasgwatson
Copy link
Contributor

Right. Makes sense, and I'll cut a separate ticket for it

@lorenjohnson
Copy link
Member

I think if you do this it should do away with scrolling delay and otherwise address the other issue you were having?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants