Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symbolic links as alternative to hard links #520

Open
hannes-ucsc opened this issue Mar 23, 2020 · 1 comment
Open

Add symbolic links as alternative to hard links #520

hannes-ucsc opened this issue Mar 23, 2020 · 1 comment
Labels
orange Done by the Azul, Data Browser and Portal team

Comments

@hannes-ucsc
Copy link
Contributor

Potential improvements on top of the mere bug fix for #519:

Add a --link-method {hard|soft|copy},... command line argument and implement the soft method using symbolic links.

The default should be --link-method=hard. To try hard links first and then fall back to copies, the user would specify --link-method=hard,copy.

Any errors that occur during the actual linking should cause a diagnostic message to be printed that alerts the user of the --link-method option.

@hannes-ucsc hannes-ucsc changed the title Add linking strategy Add symbolic links as alternative to hard links Mar 23, 2020
@hannes-ucsc
Copy link
Contributor Author

hannes-ucsc commented Mar 23, 2020

I think there currently is some code that looks at st_nlink. That logic would be thrown off by alternating between hard and soft method. Switching between hard and copy or soft and copy should be fine.

Consider persisting the link method in the filestore so that the problematic transitions can be prevented.

Note that changing the filestore format should require bumping the filestore version. If we don't bump the version, filestores created by older CLI releases would break the release that includes this feature and vice versa.

@theathorn theathorn added the orange Done by the Azul, Data Browser and Portal team label Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
orange Done by the Azul, Data Browser and Portal team
Projects
None yet
Development

No branches or pull requests

3 participants