Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gif and graphic don't match #38

Open
komalioruganti opened this issue Oct 13, 2022 · 13 comments
Open

Gif and graphic don't match #38

komalioruganti opened this issue Oct 13, 2022 · 13 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@komalioruganti
Copy link

The sun gif to the left of the page doesn't match the vector graphic on the left and are not of the same theme.

@HridoyHazard HridoyHazard added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 13, 2022
@Savio629
Copy link

Can you explain a bit more about the issue?

@Kritika30032002
Copy link

Can you explain a bit more about the issue?

yes same @komalioruganti @HridoyHazard

@Fly-Style
Copy link
Contributor

Actually, I may suggest migrating from gif format. GIF files worsen the performance of any web app for significant numbers.
If you want, I may contribute that...

@HridoyHazard
Copy link
Owner

what will u add instead of gif files?

@Fly-Style
Copy link
Contributor

I guess, I'll download used gifs, then will convert them to webp format.
Also these actions prevents network hops, which also worsen performance. To me, it's better to have them as assets in the project. WDYT @HridoyHazard?

@HridoyHazard
Copy link
Owner

give it a try...good luck

@Fly-Style
Copy link
Contributor

Just FYI: how large these gifs are

➜  asset git:(main) ✗ ll                   
-rw-rw-r-- 1 sasha sasha  20M Sep 16  2021 clear.gif
-rw-rw-r-- 1 sasha sasha 8.8M Sep 27  2021 cloud.gif
-rw-rw-r-- 1 sasha sasha 4.3M Sep 19  2021 drizzle.gif
-rw-rw-r-- 1 sasha sasha 359K Oct 16 14:24 lake-background.jpg
-rw-rw-r-- 1 sasha sasha 1.5M Oct 16 14:24 main_bg.jpg
-rw-rw-r-- 1 sasha sasha  62K Oct 16 14:24 not-found.svg
-rw-rw-r-- 1 sasha sasha 1.9M Sep  8  2021 rain.gif
-rw-rw-r-- 1 sasha sasha  84K Oct 16 14:24 search.svg
-rw-rw-r-- 1 sasha sasha 640K Sep 22  2021 snow.gif
-rw-rw-r-- 1 sasha sasha 1.6M Sep 19  2021 thunder.gif
-rw-rw-r-- 1 sasha sasha  19M Sep  7  2021 wind.gif

@Fly-Style
Copy link
Contributor

Fly-Style commented Oct 16, 2022

@HridoyHazard does it make sense for you to replace gifs with normal images? To be honest, their quality is pretty bad.

@HridoyHazard
Copy link
Owner

animation would good better than still images. that's why i put gif. can you add similar animation without ruining the performance ??

@Fly-Style Fly-Style removed their assignment Oct 22, 2022
@Brujitari
Copy link

Brujitari commented Oct 22, 2022

I can't find that 'sun gif to the left of the page' or the vector graphic, would you mind being more specific or including images?@komalioruganti

@komalioruganti
Copy link
Author

What I was trying to say was the sun gif which was in the deployed website was not matching with the rest of the theme happening in the page.
effulgent-brioche-795ac4.netlify.app/
image
But I think it has been changed now.

@komalioruganti
Copy link
Author

komalioruganti commented Oct 23, 2022

Animations in my opinion are better than images but I think thier quality should be proper and color scheme should coordinate well with the rest of the things in the page

@Brujitari
Copy link

oh ok thanks for explaining 💕 @komalioruganti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants