Fix missing max_wait argument in ::Service::Commands::Stop.run call
#800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary This PR fixes an issue in the `::Service::Commands::Stop.run` method call, where `max_wait` was referenced without being assigned a value. ### Changes - Updated the `max_wait:` argument to `max_wait: max_wait` to correctly pass the intended `max_wait` variable. ### Context The lack of a value assignment to `max_wait` resulted in an error when invoking the stop command. This change ensures that `max_wait` is now passed correctly as an argument.
MikeMcQuaid
requested changes
Nov 6, 2024
Comment on lines
152
to
+153
| max_wait = args.max_wait.to_f | ||
| ::Service::Commands::Stop.run(targets, verbose: args.verbose?, no_wait: args.no_wait?, max_wait:) | ||
| ::Service::Commands::Stop.run(targets, verbose: args.verbose?, no_wait: args.no_wait?, max_wait: max_wait) |
There was a problem hiding this comment.
@albertterradas What Ruby version are you running? The existing syntax is valid on the version of Ruby that Homebrew requires.
|
Closing due to lack of response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue in the
::Service::Commands::Stop.runmethod call, wheremax_waitwas referenced without being assigned a value.Changes
max_wait:argument tomax_wait: max_waitto correctly pass the intendedmax_waitvariable.Context
The lack of a value assignment to
max_waitresulted in an error when invoking the stop command. This change ensures thatmax_waitis now passed correctly as an argument.