Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazycat 1.0.96 (new cask) #178232

Merged
merged 1 commit into from
Jul 3, 2024
Merged

lazycat 1.0.96 (new cask) #178232

merged 1 commit into from
Jul 3, 2024

Conversation

huhu415
Copy link
Contributor

@huhu415 huhu415 commented Jul 1, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

i do not know Checked the cask was not means, is this pr ok?

@BrewTestBot BrewTestBot added new cask missing description Cask is missing a description, please add one. missing zap Cask is missing a zap stanza, please add one. labels Jul 1, 2024
@huhu415
Copy link
Contributor Author

huhu415 commented Jul 1, 2024

what is wrong , what should I change ?

@SMillerDev
Copy link
Member

Why did you call the PR transmission 1.0.96 (new cask) when you're not making a PR to add a transmission cask?

Casks/l/lazycat.rb Outdated Show resolved Hide resolved
Casks/l/lazycat.rb Outdated Show resolved Hide resolved
@krehel krehel added the awaiting user reply Issue needs response from a user. label Jul 1, 2024
@huhu415
Copy link
Contributor Author

huhu415 commented Jul 1, 2024

I finally passed all the tests

Casks/l/lazycat.rb Outdated Show resolved Hide resolved
Casks/l/lazycat.rb Outdated Show resolved Hide resolved
@krehel krehel changed the title transmission 1.0.96 (new cask) lazycat 1.0.96 (new cask) Jul 1, 2024
@krehel krehel requested a review from chenrui333 July 1, 2024 13:33
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a zap stanza here. The CreateZap tool can help you with this.

Casks/l/lazycat.rb Outdated Show resolved Hide resolved
@BrewTestBot BrewTestBot removed the missing zap Cask is missing a zap stanza, please add one. label Jul 1, 2024
@huhu415
Copy link
Contributor Author

huhu415 commented Jul 1, 2024

I have a question for you 🙋, if the user uninstalls without executing brew uninstall --zap firefox, is there any way to remove those files afterwards?

@huhu415
Copy link
Contributor Author

huhu415 commented Jul 1, 2024

I finally passed all the tests again

@bevanjkay bevanjkay added ci-skip-token Skip `token_*` audit. Use only for valid exceptions. and removed ci-skip-token Skip `token_*` audit. Use only for valid exceptions. labels Jul 2, 2024
Casks/l/lazycat.rb Outdated Show resolved Hide resolved
@BrewTestBot BrewTestBot removed the missing description Cask is missing a description, please add one. label Jul 3, 2024
@huhu415
Copy link
Contributor Author

huhu415 commented Jul 3, 2024

Okay, I've changed it to English.

@bevanjkay bevanjkay added awaiting maintainer feedback Issue needs response from a maintainer. and removed awaiting user reply Issue needs response from a user. labels Jul 3, 2024
Signed-off-by: Justin Krehel <[email protected]>
@bevanjkay bevanjkay enabled auto-merge July 3, 2024 11:53
@bevanjkay bevanjkay merged commit 1e2fbca into Homebrew:master Jul 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting maintainer feedback Issue needs response from a maintainer. new cask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants