Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launchpad-manager: use versioned url, add legacy version #177510

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

khipp
Copy link
Contributor

@khipp khipp commented Jun 22, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@khipp
Copy link
Contributor Author

khipp commented Jul 2, 2024

@bevanjkay Are there any issues left, or is this good to go? 😊

@bevanjkay bevanjkay merged commit 8291901 into Homebrew:master Jul 3, 2024
9 checks passed
@khipp khipp deleted the update-launchpad-manager branch July 3, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants