Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orka-desktop 3.0.0-beta.1 (new cask) #177473

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

cameronbroe
Copy link
Contributor

@cameronbroe cameronbroe commented Jun 21, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

New cask audit fails notoriety check as this is a relatively new product from MacStadium. We already have a few other Orka related tools distributed as Casks though.

Add new cask for new beta release of Orka Desktop with new integrations with Orka Cluster 3.0+
@p-linnane p-linnane added the ci-skip-repository Skip repository checks on CI. Use only after repository has been verified manually. label Jun 21, 2024
@p-linnane
Copy link
Member

Hi @cameronbroe. Thanks for the PR. Do you plan on having additional beta releases in the future? If not, we can just make this a stable cask, and update it with stable versions moving forward.

@cameronbroe
Copy link
Contributor Author

Hello, @p-linnane. After some discussion with the team, we're not entirely sure how much of a need there is going to be for additional beta releases other than between major versions updates. We do think it may just be best to go on and make this a stable cask though short-term while we consider how we want to handle pre-release versions going forward. Does this make sense to you as well?

@bevanjkay
Copy link
Member

If the current beta is the "most stable" release available, then yes we can go ahead and make this orka-desktop, and then later on if there are subsequent beta releases a second orka-desktop@beta cask can be added if required.

@cameronbroe cameronbroe force-pushed the cr/add-orka-desktop-beta-cask branch from 6675bc1 to d90d391 Compare July 1, 2024 15:43
@bevanjkay bevanjkay added the ci-skip-token Skip `token_*` audit. Use only for valid exceptions. label Jul 2, 2024
Casks/o/orka-desktop.rb Outdated Show resolved Hide resolved
@p-linnane p-linnane merged commit 33abf33 into Homebrew:master Jul 3, 2024
9 checks passed
github-actions bot pushed a commit to MPLew-is/homebrew-vscodium that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip ci-skip-repository Skip repository checks on CI. Use only after repository has been verified manually. ci-skip-token Skip `token_*` audit. Use only for valid exceptions. new cask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants