Add support for vscode extensions

[MikeMcQuaid]

Allow them to be installed, dumped, checked and cleaned up.

While we're here:

• pass --formula for a few other installations
• brew services can now run on Linux

[colindean]

My only suggestion is around including VSCodium. I use it as much as I use VSCode, which is mostly just on my comp survey project (VSC's Jupyter + Python support is rad). The machine on which I actively use VSCodium is many miles away right now so I can't test to see if it installs a code executable. All I could confirm is that it does install a codium executable. Someone aliasing with alias code=codium would fix that problem in the meantime.

I'm not 100% sold on this but I could see the utility. I don't use Atom any more but at one point tracked packages and installed them using something I'd certainly preferred be built into something else.

Adding VSCode support kinda makes me want to add in Jetbrains IDEs extension installation. It'd reduce the amount of "oh, you need plugins X, Y, Z" for my team…

[MikeMcQuaid]

Reasoning for this: 3+ people I've spoken to in person said they would use this and the impact on people without VSCode in their PATH is essentially nil.

I would support JetBrains plugins and other similar things. The more things we support: the more useful Homebrew Bundle is for people.

The future PR I may add is 1Password support to be able to dump secrets into specified locations on disk.

[jacobbednarz]

I'm happy with the explicit approach here but do wonder if we should make the interface more configurable given the desire above to extend it eventually for more tools. something like extension "<extension name>" provider: vscode would also address the comments about vscode variants and future editors.

examples

extension "GitHub.codespaces" provider: vscode
extension "GitHub.codespaces" provider: vscodium
extension "GitHub.codespaces" provider: vscode-insiders
extension "GitHub.codespaces" provider: jetbrains

not sold on the nomenclature of provider but 🤷‍♂️

[colindean]

That almost kinda begs for

extensions provider: :vscode do
  ext "GitHub.codespaces"
end
extensions provider: :jetbrains do
  app :pycharm do
    ext "pylint"
  end
  app :intellij do
    ext "scala"
  end
end

but this is probably too verbose.

[MikeMcQuaid]

Cool ideas but let's not blow up the scope here. VSCode, VSCodium and even JetBrains can get support added later by either of you who want it personally. Keeping this non-generic makes the DSL and the code simpler and more readable.

[colindean]

Yeah, I'm very 👍 on this now that I understand the trajectory of what you're aiming to enable.

[jacobbednarz]

after looking at this some more, i am a little concerned if we introduce vscode "..." and later expand the interface to more editors, this is going to be a difficult backwards compatibity change we would have to make in order to support it in a uniform way. do we want to generalise the interface now but only add vscode support?

[MikeMcQuaid]

we would have to make in order to support it in a uniform way

I do not want to support this in a more uniform way e.g. extensions.

do we want to generalise the interface now but only add vscode support?

No. I do not want to generalise this ever, sorry 😄.

I am game to have jetbrains added or support for codium or code-insiders if someone who uses this wants them but I don't want to increase the scope on this PR for things I'm not yet convinced people want or to make the interface far less readable in the interests of making it generalisable.

Thanks for review/comments anyway folks ❤️

[philoserf]

This change adds vscode extension removal to brew bundle cleanup. That it will remove extensions not installed by Homebrew is not okay.

[MikeMcQuaid]

This change adds vscode extension removal to brew bundle cleanup

No, it doesn't. It adds it to brew bundle cleanup --force. If you choose to run that regularly without running brew bundle cleanup first: that's your bad.

[philoserf]

I see the fix is in already. #1210

[PatrickF1]

YES thank you for adding this @MikeMcQuaid ! Dunno if you were planning on it, but I'd recommend making some sort of announcement about this because I only found out when I ran brew bundle and was pleasantly surprised by the vscode lines at the bottom.

[MikeMcQuaid]

Thanks @PatrickF1! We'll likely announce this in the next public major or minor release.