From fda41919cf396cf1ab7a6fe51aead448e21f93dd Mon Sep 17 00:00:00 2001 From: mansimarkaur Date: Mon, 3 Apr 2017 07:06:59 +0530 Subject: [PATCH 1/2] Added test for check_access_lock_dir --- Library/Homebrew/test/diagnostic_spec.rb | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/Library/Homebrew/test/diagnostic_spec.rb b/Library/Homebrew/test/diagnostic_spec.rb index 59560127cb604..c4ff1f4588a16 100644 --- a/Library/Homebrew/test/diagnostic_spec.rb +++ b/Library/Homebrew/test/diagnostic_spec.rb @@ -41,6 +41,18 @@ end end + specify "#check_access_lock_dir" do + begin + mode = HOMEBREW_LOCK_DIR.stat.mode & 0777 + HOMEBREW_LOCK_DIR.chmod 0555 + + expect(subject.check_access_logs) + .to match("#{HOMEBREW_LOCK_DIR} isn't writable.") + ensure + HOMEBREW_LOCK_DIR.chmod mode + end + end + specify "#check_access_logs" do begin mode = HOMEBREW_LOGS.stat.mode & 0777 From 7e455a623a3f49f63b589ea31d72c860b1d33c06 Mon Sep 17 00:00:00 2001 From: mansimarkaur Date: Fri, 7 Apr 2017 18:29:40 +0530 Subject: [PATCH 2/2] Corrected test for access_lock_dir --- Library/Homebrew/test/diagnostic_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/test/diagnostic_spec.rb b/Library/Homebrew/test/diagnostic_spec.rb index c4ff1f4588a16..c2bcdb9c03153 100644 --- a/Library/Homebrew/test/diagnostic_spec.rb +++ b/Library/Homebrew/test/diagnostic_spec.rb @@ -46,7 +46,7 @@ mode = HOMEBREW_LOCK_DIR.stat.mode & 0777 HOMEBREW_LOCK_DIR.chmod 0555 - expect(subject.check_access_logs) + expect(subject.check_access_lock_dir) .to match("#{HOMEBREW_LOCK_DIR} isn't writable.") ensure HOMEBREW_LOCK_DIR.chmod mode