Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests broken on new release on ECL #2

Open
jgarte opened this issue Oct 7, 2023 · 3 comments
Open

Tests broken on new release on ECL #2

jgarte opened this issue Oct 7, 2023 · 3 comments

Comments

@jgarte
Copy link

jgarte commented Oct 7, 2023

Looks like the latest release version of enhanced-eval-when breaks the tests for canonicalized-initargs on ECL:

;;; Error:
;;;   in file tests.lisp, position 507
;;;   at (DEFCLASS CANON-BOOLEAN ...)
;;;   * The macro form (DEFCLASS CANON-BOOLEAN NIL ((%BOOLEAN :INITARG :BOOLEAN :READER %BOOLEAN :CANONICALIZE (FUNCTION BOOLEAN)))) was not expanded successfully.
;;; Error detected:
;;; In function CAR, the value of the first argument is
An error occurred during initialization:
#<a FLOATING-POINT-INVALID-OPERATION 0x7ffff4b624c0>.

WDYT

@Hexstream
Copy link
Owner

Thank you! Interesting information.

Traditionally, I have only (comparatively) heavily tested on SBCL and lightly tested on CCL, but also lightly testing on ECL seems like it could be worthwhile, so I'll try installing ECL and reproducing your issue and then get back to you.

@Hexstream
Copy link
Owner

Hum, unfortunately, it seems properly running ECL with Quicklisp is not that easy on my machine, due to a conflict with the system-provided ASDF, which I need for my StumpWM. I don't really want to mess with my system.

I have enough urgent fires on my roadmap that adding proper support for ECL is not a top priority, and that would be much easier to do once my unit testing framework is ready, allowing me to vastly and easily expand my unit testing practices.

I would be pretty surprised if this was the only ECL issue across all my libraries anyway, so I think it would be best to add proper support for ECL later, hopefully in 2024 or 2025. There are probably other Common Lisp implementations worth supporting explicitly, too.

Sorry for any inconveniences caused!

@jgarte
Copy link
Author

jgarte commented Oct 7, 2023

No probs, I'll just disable the ECL tests for your library or disable the ECL guix package altogether until it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants