New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RingResonator Circumference missing vertical racetrack contributions #66

Open

rkberlin opened this issue Aug 24, 2023 · 0 comments

rkberlin commented Aug 24, 2023

The current implementation of the RingResonator circumference

@Property
def circumference(self):
return 2 * np.pi * self.radius + 2 * self.race_length

lacks the contribution of the optional vertical racetrack section and should be

@Property
def circumference(self):
return 2 * np.pi * self.radius + 2 * self.race_length + 2 * self.vertical_race_length

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment