-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plotSpillmat() not plotting all channels in heatmap #204
Comments
Could you post dimnames(sm) as well as ss_chs? Thx! |
[[2]]
Took away my channel names to keep my panel "secret" :) hehe... |
Do you want me to send you a sample data file and the comp beads? |
I think this is not an error per se.
|
Hi, dimnames [[2]] ss_chs |
just found out that the matrix is plotted correctly when all unnecessary channels are deleted (used premessa here) in combination with the standard isotope_list without changes (so no more 190BCKG and also some empty Ce and Lu channels. It is a workaround but it fixes the problem for now. |
Nice workaround! But this wont resolve the issues for me, i need some channels in the data that i do not have compensation beads for. cisplatin staining for example:) |
Hi @HelenaLC |
Hi, I recently compensated some data using the same number of comp channels i had in my original post. This time the whole spillmat was printed out with no missing channels. Maybe this is the result of different preprocessing, but maybe an update has been published? |
Hi, |
Hi, |
@nilseling I got a prototype that should resolve all this and works a little different. Would you be willing and able to give it a try? Hard for me to test as I'm not working with this data in real life and have only tried to mess up the example data and see to that working... |
Hi @HelenaLC, for sure! I'm more than happy to test this :) which branch should I use? Thanks for working in this. |
Great, thanks! RELEASE_3_16 (on GH only; working on some other fixes before going Bioc). Happy to discuss... There's a bit of a design choice (hard to explain) regarding whether or not to include empt rows/columns. basically, a full matrix is easier to read (clear diagonal), but might give unnecessary white space (depending on the overall mass range)... And, I made a not-insignificant change that cuts out empty columns (empty = no spill) to reduce the overall width. Any feedback welcome! |
So it looks better. Thanks for fixing it. However, I noticed that
The previous visualization looked like this: I believe the issue comes from the fact that there was no spillover detected between these and any other channels. In the best case I would say to visualize all channels that are in the spillover matrix. |
I see. Could you share the object with me? Should be an easy fix. |
Super sorry for the late reply. I now attach the spillover matrix. |
Hi @HelenaLC, has there been any progress in enabling the plotSpillmap function to plot all channels present in the data? Currently, I am missing everything above 175Lu (I have 176Yb, all four platinums, and 209Bi). Best regards. |
Hi,
This is a small issue im not able to debug myself. I get a nice plot of the spillover matrix but many of the channels are missing. first time running the code, it plotted up to, and including, 157Gd (im using that channel). I then ran the code again after also including five cadmium channels. Now plotSpillmat() plotted up to and including 162. seems like ut only plots a certain number of channels counting from 141.
comp_file <- "/Users/.. compBeads1_01_1.fcs"
sce_comp <- prepData(comp_file, transform = TRUE)
Debarcode the single stained beads
bc_ms <- c(89, 111:114, 116, 141:176, 209)
sce_comp <- assignPrelim(sce_comp, bc_ms, verbose = FALSE)
sce_comp <- applyCutoffs(estCutoffs(sce_comp))
compute & extract spillover matrix
sce_comp <- computeSpillmat(sce_comp)
sm <- metadata(sce_comp)$spillover_matrix
do some sanity checks
chs <- channels(sce_comp)
ss_chs <- chs[rowData(sce_comp)$is_bc]
all(diag(sm[ss_chs, ss_chs]) == 1)
all(sm >= 0 & sm <= 1)
plotSpillmat(sce_comp)
The text was updated successfully, but these errors were encountered: