Key Mapping doesn't seem to update while building

[SpaceDriedVest]

So glad I came across this project and I even hope to start contributing to it too!

I've tried taking an rp2040 example and updated the size of the matrix and the keymapping.

The changes were made in keymap.rs, keyboard.toml, and vial.json. I see additional defmt log statements I added being printed but the key is still responding with the original keymap from the example.

I'm loading via cargo run using an RPi Pico Probe to a RPi Pico. Am I missing some step in getting the new config to be recognized and built?

Thanks!

[HaoboGu]

Could you post your keymap.rs, keyboard.toml, vial.json and main.rs here?

[SpaceDriedVest]

Sure thing, here they are:

keymap.rs

use crate::{COL, NUM_LAYER, ROW};
use rmk::action::KeyAction;
use rmk::{k, layer};

#[rustfmt::skip]
pub static KEYMAP: [[[KeyAction; COL]; ROW]; NUM_LAYER] = [
    layer!([
        [k!(Kc1)]
    ])
];

keyboard.toml

[keyboard]
product_name = "RMK Keyboard"
vendor_id = 0x4c4b
product_id = 0x4643
manufacturer = "haobo"
chip = "rp2040"


[matrix]
rows = 1
cols = 1
layers = 1
# TODO: Update input/output gpio name
# Input and output pins are mandatory
input_pins = ["PIN_10"]
output_pins = ["PIN_6"]
# WARNING: Currently row2col/col2row is set in RMK's feature gate, configs here do nothing actually
# row2col = true

[layout]

[light]
# All light pins are high-active by default, uncomment if you want it to be low-active
# capslock.pin = "PB2"
# capslock.low_active = true
# scrolllock.pin = "PA3"
# scrolllock.low_active = true
# Just ignore if no light pin is used for it
# numslock.pin = "PA5"
# numslock.low_active = true

[storage]
# Storage feature is enabled by default
# enabled = false

vial.json

{
    "name": "HID Keyboard",
    "vendorId": "0x4C4B",
    "productId": "0x4643",
    "lighting": "none",
    "matrix": {
        "rows": 1,
        "cols": 1
    },
    "layouts": {
        "labels": [
            [
                "label"
            ]
        ],
        "keymap": [
            [
                "0,0"
            ]
        ]
    }
}

main.rs

#![no_std]
#![no_main]


mod keymap;
mod vial;

use crate::keymap::KEYMAP;
use rmk::macros::rmk_keyboard;
use vial::{VIAL_KEYBOARD_DEF, VIAL_KEYBOARD_ID};

#[rmk_keyboard]
mod keyboard {}

[HaoboGu]

I tried your configs on my rp2040 board, it works correctly. Which folder do you run your cargo run command? Make sure running cargo run in examples/use_config/rp2040.

You can use cargo size to check the binary size before and after changing the config. Your new config should have smaller binary size generated.

[HaoboGu]

@SpaceDriedVest Do you still have the problem? I cannot repro your case.

[flamestro]

I had a similar issue, for me it was resolved by running cargo clean followed by cargo run --release instead of cargo run.

Hope it helps others

[HaoboGu]

I had a similar issue, for me it was resolved by running cargo clean followed by cargo run --release instead of cargo run.

Thanks for the feedback, I would try to fix it.

[flamestro]

Hey, thanks for checking this. i did not use a keyboard.toml but only a .rs

[HaoboGu]

Got it. It's so weird, I cannot repro this on my mac. Could you provide a little bit more info? such as your OS, Rust version, RMK version, etc.

[flamestro]

I used a macOS Intel device with a recent version of rust (I can check later).

I used the examples/use_rust/rp2040 config and flashed it by changing the pins only. (I have 3x3 but the config is 4x3) This worked without issues. Then i changed the rows and cols in the vial.json because it was not update by cargo build. I also changed the rows and cols in the keymap.rs to 3x3 and adjusted the keys to others.

I ran cargo build and then cargo run as specified in the Readme.

It did not work until I tried a cargo clean and cargo run --release. It did also not work without the release.

Oh and I flashed using usb without a debug probe.

Somewhere in between all this I also adjusted the build.rs to always run and not only if the memory.x is changed. Not sure when tho, I just not it did not work before and after this change, but I removed the line until the end.

[HaoboGu]

Thanks for the info! I will dig into it soon

[HaoboGu]

@flamestro The latest commit should fix the issue, could you please test it again? Thanks!

[flamestro]

Sure, I will check it until tomorrow. I anyways had to flash a new keyboard so I can try it on a fresh rp2040 :)

[flamestro]

I can't reproduce the issue anymore

[HaoboGu]

Thanks! I'm closing this issue