-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RuleEditWindow: re-arrange tests/actions #11
Comments
I don't quite understand this. Could you please explain further? |
(What's below applies equally to the 'test sections' ("When"). With the "Add" button, you can add actions in the "Do" section of the rule window. After you've added a few, you can't remove e.g. the second action after you added a third. The "Remove" button always deletes the last added action. I suppose "+" and "-" buttons to the right of the text field of an action instead of the "Add/Remove" buttons could work. Then you can exactly say which action to remove or where to add a new one (below the one you clicked the "+"). |
We can remove (and add after) the row in which the text field has the keyboard focus. That way, we wouldn't have to add the "+" and "-" button. What do you think? |
I'd prefer the +/- buttons because it's so much more obvious. |
I am thinking about redesigning this window and make it a BColumnListView if the class can be extended to support additional ColumnTypes. If feasible, a +/- button for every row would look repetitive? Wouldn't it better to have one +/- button below the view? |
I'm not sure you can put popup menus into a "cell" of a BColumnListView. And I don't know if a BColumnListView is really suited for this. Mabe if you could create a crude mockup... |
Never mind. I thought it would be easy to add new column types to ColumnTypes.cpp. I was thinking about making the Test view (the When box) a list view with one test per row. Then the user would be able to navigate to any row using the up/down arrow keys. The current row would be highlighted, so one pair of add/remove buttons below the list view would work. (Add would mean insert before the current row.) Same with the Do box. |
I still prefer the +/- buttons for every row. Even if you put a "knobbly" widget like the Deskbar tray has to move the Deskbar to different locations, it's not obvious that you can re-order rows and how. |
This issue can be closed as it's fixed by @humdingerb with 33c22ea. |
Not really. This tickets is about re-arranging the test/actions in the "Edit rule" window. |
Oops! I got the two mixed up. |
It'd be nice to be able to re-arrange test views and action views via drag&drop. Currently you'll have to remove all the tests/actions one by one from the bottom up, and recreate them in the new order...
The text was updated successfully, but these errors were encountered: