Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assay name is mandatory in specification but validator does not complain #213

Open
nilshoffmann opened this issue Jul 25, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@nilshoffmann
Copy link
Member

https://github.com/HUPO-PSI/mzTab/blob/master/specification_document-releases/2_0-Metabolomics-Release/mzTab_format_specification_2_0-M_release.adoc#6234-assay1-n
states that an assay name is mandatory.
For the https://github.com/HUPO-PSI/mzTab/blob/master/examples/2_0-Metabolomics_Release/MouseLiver_negative.mzTab example, assay names are not set, but validation is successful.

@nilshoffmann nilshoffmann self-assigned this Jul 25, 2024
@nilshoffmann nilshoffmann added this to the mzTab-M 2.1.0 milestone Jul 25, 2024
@nilshoffmann
Copy link
Member Author

nilshoffmann commented Jul 25, 2024

The current validator implementation does not complain if assay name is not defined. Updating the specification would allow existing implementations to stay the same. The specification should be updated to make the assay name optional, but recommended to be reported, if feasible / helpful for the current use case. The validator could be updated to report an Info level message that reporting an assay name is recommended.

@nilshoffmann nilshoffmann changed the title Assay name is mandatory but mouse liver example does not have one Assay name is mandatory in specification but validator does not complain Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant