Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvements #44

Open
ghost opened this issue Jan 23, 2022 · 5 comments
Open

UI Improvements #44

ghost opened this issue Jan 23, 2022 · 5 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Jan 23, 2022

After examining this userChrome, I can confidently say it is one of the best ways to merge Firefox with the Windows UI (especially Windows 11). But I've seen some inconsistencies, as given below.

  1. The toolbar is too compact for me. I like to use the Normal mode, despite of what people say about the Proton redesign.
  2. Ability to use custom themes is missing!
  3. Tabs should be more rounded, like Microsoft Edge, or the default Proton tabs would look good enough.
  4. The hamburger menu is shifted (a little bit) to the left. This makes no sense, and I guess it's a bug. (See attachment for reference.)
    image
  5. Some buttons bigger than expected.
    image
    image

Looking forward to the development of this project!

@Guerra24
Copy link
Owner

  1. This is expected, since compact theme was hidden behind a pref the normal mode was converted into the compact mode.
  2. This is expected too. I can check if it could be fixed.
  3. Exist in WIP form by creating another bool pref uwp.sun-valley.round-tabs, it was not kept as default since it has some issues.
  4. This is due to the shadows. It can be reduced but not removed entirely, I'll look into it.
  5. I'm aware some parts looks kinda unfinished, I haven't had time to work more on it unfortunately.

@Guerra24 Guerra24 added bug Something isn't working enhancement New feature or request labels Jan 23, 2022
@ghost
Copy link
Author

ghost commented Jan 24, 2022

Please take your time. I'm looking forward to newer updates.
Thanks for the fast responses.

Guerra24 added a commit that referenced this issue Feb 6, 2022
Also fix fullscreen warning not using the correct color in light mode.
Guerra24 added a commit that referenced this issue Mar 25, 2022
Also fix button's active state not working due to typo...
Guerra24 added a commit that referenced this issue Mar 25, 2022
@Guerra24
Copy link
Owner

Margin reduced a bit. This is gonna need a bit of tweaking down the road due to it being different in both styles.
image

Download buttons should look way better now.
firefox_2022-03-25_02-26-55

@ghost
Copy link
Author

ghost commented Mar 25, 2022

Thank you! Download buttons look perfect.

@ghost
Copy link
Author

ghost commented Jul 5, 2022

image
Just here to say, thank you for the new improvements. That slight border around the tab is a great improvement! I no longer get confused between the active and inactive tabs like I used to before :P
The hamburger menu looks way better now too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant