-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required flag silently not honored when including a partial schema. #141
Comments
@mschaef-da What version are you running? The specified YAML data blob fails validation on my end
Tested with latest git commit. |
|
Did you not include the entire datablob that would match against that specified schema? |
Argh... apologies for the mistake. The data file should read like this:
I've since also tested against 1.7.0:
|
Ye, i start to think that i need to rewrite the rule engine to sort this out, the lazy loading way that i am currently doing is causing more issues then what it is worth. I guess i have to fix the issues with infinite recursion problem some other way and then most of these kinds of issues would be sorted out itself. |
@mschaef-da Could you try the new branch i made in #143 to see if this solves your issue from your end? It looks promising with the rebuilded include feature, but i need more tests from real-world to verify that it works as i want. |
@mschaef-da Issue resolved inside branch feature/rebuild-include Closing this as fixed for now. |
This YAML:
Gives this result:
When validated against this schema:
It looks like #85 was work on a similar scenario, but it seems like either the required flag at the
include
site should be ignored, or a warning/error should be issued signaling that this is not a valid schema definition.The text was updated successfully, but these errors were encountered: