-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Best practices for redux-based plug-in architecture #57
Comments
Hey there and thanks for asking! The ideas here are based on a lot of other things but it was something we started doing without much input from other React/Redux projects. The initial idea came about before we were using Redux (at the time we were using a homegrown flux library that was using Immutable for state and a series of reducers). We were super thrilled when Redux came out since it allowed us to focus more on the grid-specific code but we kept the similar "plugin" ideas that we were originally planning on using. While this works for our grid, it would be nice if there was something more reusable for any project using React+Redux. I have not researched this too much so this could totally exist and I may be unware 😄. Please keep us updated if you find anything more on this! |
+1 |
Hey there, I am trying to understand this portion of the docs:
A few questions:
Thanks for helping me understand your system. As I said above, it is very intriguing. I think many people will be interested in figuring out a set of best-practices for designing plug-in architectures based on react+redux. |
Thanks for asking - we definitely can improve that part of the documentation to be clearer.
The output from the reducers gets passed into the connector which becomes the props on the Griddle view components. As a side note, I'm also exploring using reselect in the reducers to help slim down what data gets passed through the connector.
Please let me know if that helps clear anything up or any ideas you may have around that. I would love to see a more widely embraced pattern emerge (and again it's totally possible there is something out there I'm missing that would serve these same needs 😄) 👍 |
Wanted to note this here -- we're currently in the process of removing helpers in favor of selectors. (See this branch). As noted above, helpers were an artifact of an earlier architecture and selectors should mostly accomplish everything we were using them for (with the added performance boost given by reselect's default memoization). Additionally, pushing most of the logic to the selectors is allowing us to simplify our reducers quite a bit. |
Hey there,
I recently stumbled upon your work with griddle 1.0 and am very intrigued by it. I'm just wondering if the plug-in architecture you're using is based on prior work, or if it is something that you yourselves are pioneering.
Have you done a search of how other developers are building plugin-able architectures on top of redux?
I'm currently trying to create an IDE of sorts for biology, and so am looking for best practices when it comes to building a reusable, plug-in-based architecture with react+redux.
Thanks for your time,
Thomas
The text was updated successfully, but these errors were encountered: