Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake] project_name and var as full uppercase or lowercase but not camel case #140

Open
clementval opened this issue Mar 2, 2018 · 1 comment

Comments

@clementval
Copy link
Collaborator

clementval commented Mar 2, 2018

When using find_package, we have to use Serialbox and not serialbox or SERIALBOX. I find it confusing and also for other variables used later.
When using the exported package information of serialbox2, we have to provide the directory with -DSerialbox_DIR=<path-to-cmake-folder-in-install>.
In my opinion this is not quite friendly and would be better with SERIALBOX_DIR= or serialbox_dir=. This is picky change but then necessary 😄

I would gladly make the change if you guys agree on this. @havogt @phmarti ??

@clementval clementval changed the title [CMake] export var as full uppercase or lowercase but not camel case [CMake] project_name and var as full uppercase or lowercase but not camel case Mar 2, 2018
@havogt
Copy link
Collaborator

havogt commented Aug 21, 2018

I think I don't agree as this is (unfortunately) the standard CMake pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants