You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using find_package, we have to use Serialbox and not serialbox or SERIALBOX. I find it confusing and also for other variables used later.
When using the exported package information of serialbox2, we have to provide the directory with -DSerialbox_DIR=<path-to-cmake-folder-in-install>.
In my opinion this is not quite friendly and would be better with SERIALBOX_DIR= or serialbox_dir=. This is picky change but then necessary 😄
I would gladly make the change if you guys agree on this. @havogt@phmarti ??
The text was updated successfully, but these errors were encountered:
clementval
changed the title
[CMake] export var as full uppercase or lowercase but not camel case
[CMake] project_name and var as full uppercase or lowercase but not camel case
Mar 2, 2018
When using
find_package
, we have to useSerialbox
and notserialbox
orSERIALBOX
. I find it confusing and also for other variables used later.When using the exported package information of serialbox2, we have to provide the directory with
-DSerialbox_DIR=<path-to-cmake-folder-in-install>
.In my opinion this is not quite friendly and would be better with
SERIALBOX_DIR=
orserialbox_dir=
. This is picky change but then necessary 😄I would gladly make the change if you guys agree on this. @havogt @phmarti ??
The text was updated successfully, but these errors were encountered: