Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify asymmetry of get_all_unitary_topologies_set and get_all_unitary_topologies_change. #677

Open
MatthijsdeJ opened this issue Dec 18, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@MatthijsdeJ
Copy link

MatthijsdeJ commented Dec 18, 2024

The functions get_all_unitary_topologies_set and get_all_unitary_topologies_change do not return symmetric (w.r.t busbar) actions. This behavior is not documented. It would be good to clarify this.

I suggest the modification:

To be valid a topology must satisfy:

        - there are at least one side of the powerline connected to each busbar (there cannot be a load alone
          on a bus or a generator alone on a bus for example)
        - the topology is not a symmetric copy (w.r.t. one busbar) to an already determined topology
        - if `add_alone_line=False` (not the default) then there must be at least two elements in a 
          substation
@MatthijsdeJ MatthijsdeJ added the documentation Improvements or additions to documentation label Dec 18, 2024
@BDonnot
Copy link
Collaborator

BDonnot commented Dec 18, 2024

Hello,

You are totally correct. The mentioned methods return the list of unique possible topology for each type of actions, considering all elements are connected.

For example, if a substation counts 4 elements, then the topologies:

  • (1,1,2,2)
  • (2,2,1,1)

Will give the exact same output.

Indeed in both cases the elements 1 and 2 are directly linked together, and the element 3 and 4 are directly linked together. But (1,2) and (3,4) are not directly linked together.

I'll try to be more clear on the description of these methods.

I hope it clarify the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants