Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache IP address geolocation api calls? #108

Open
andreww opened this issue Aug 7, 2024 · 0 comments
Open

cache IP address geolocation api calls? #108

andreww opened this issue Aug 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@andreww
Copy link
Collaborator

andreww commented Aug 7, 2024

If it's not provided by the user or configuration file, we try geolocation to find out where we are on line 116 of configure.py: r = requests.get("https://ipapi.co/json/") It would be easy to cache these calls (like we do for the carbon intensity API calls). Worth doing?
@andreww andreww added the enhancement New feature or request label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andreww