Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger warning if configuration source is providing an unknown property #129

Open
todvora opened this issue Jul 31, 2024 · 1 comment
Open
Labels

Comments

@todvora
Copy link
Contributor

todvora commented Jul 31, 2024

Configuration files idea: should we warn if you configure a property that we don't know? Opensearch does this and it helps to realize you are doing something that isn't working. Last time I've seen an usage of disable_security in datanode, but the actual property is called insecure_startup . By triggering an error or at least warning, we'd tell the user that they are trying to do something that we don't understand. It would remove some portion of trial and error during configuration.

@bernd
Copy link
Member

bernd commented Aug 6, 2024

We talked about this topic outside of GitHub

The summary is that (in Graylog) we want to emit a log warning when a configuration file contains unknown properties. We don't want to throw an error and abort the server startup. Users might have older config settings in their config which are currently ignored. Stopping the server startup would be a breaking and inconvenient change for those users. The opposite might also happen, with users adding new options to the config files to prepare an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants