Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suggest running task news if there's no news to share #3499

Open
djmitche opened this issue Jun 20, 2024 · 2 comments
Open

Do not suggest running task news if there's no news to share #3499

djmitche opened this issue Jun 20, 2024 · 2 comments
Labels
good first issue Good for newcomers topic:news Issues related to `task news`

Comments

@djmitche
Copy link
Collaborator

Currently, if we make a release with no new news items, users will be reminded to run task news because the current version is newer than their news.version config. However, when they do so they will be told nothing is new. That's not a great UX - better to just not remind them if there are no new news items.

This will probably require moving the reminder out of CmdCustom.cpp and into CmdNews.cpp, which can calculate whether there are any news items to show. In fact, it's probably best to factor all of that out into a src/News.{h,cpp} which both CmdCustom.cpp and CmdNews.cpp refer to.

@djmitche djmitche added good first issue Good for newcomers topic:news Issues related to `task news` labels Jun 20, 2024
@djmitche
Copy link
Collaborator Author

Split from #3196.

@djmitche
Copy link
Collaborator Author

If 3.1.0 doesn't have any other news to share, we should do this in 3.1.0. I think at least the task purge support will have a news item, so this is probably OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers topic:news Issues related to `task news`
Projects
Status: Backlog
Development

No branches or pull requests

1 participant