-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-hermetic basename
tool
#141
Comments
jjmaestro
added a commit
to jjmaestro/rules_distroless
that referenced
this issue
Dec 16, 2024
Fixes GoogleContainerTools#141 In GoogleContainerTools#99 I added a dependency to basename when it's not really needed. Credit and thanks to @birunts for finding the dependency and providing a potential solution!
jjmaestro
added a commit
to jjmaestro/rules_distroless
that referenced
this issue
Dec 17, 2024
Fixes GoogleContainerTools#141 In GoogleContainerTools#99 I added a dependency to basename when it's not really needed. Credit and thanks to @birunts for finding the issue and providing the solution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A
genrule
from deb_import.bzl is using non-hermeticbasename
tool.This is very simple case here to grab only the file name without any sophisticated usage. Seems to be reasonable to use simple POSIX instead e.g.:
The text was updated successfully, but these errors were encountered: