Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow notebook resources composition #88

Open
proppy opened this issue Nov 15, 2022 · 1 comment
Open

allow notebook resources composition #88

proppy opened this issue Nov 15, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@proppy
Copy link
Member

proppy commented Nov 15, 2022

Is your feature request related to a problem? Please describe.

Currently when user instanciate modules with notebooks, rad-lab will provision notebook_count x notebooks with the same resource parameters.

While this convenient for simple deployment using the radlab cli/gui, terraform root module managing rad-lab deployment often need to tweak instance classes and other parameter like disk size per notebooks associated to a given project (see for example proppy/rad-lab-deploy#5).

Describe the solution you'd like

I wonder if we could expose the terraform configuration as separate module (similar to what's discussed in https://developer.hashicorp.com/terraform/language/modules/develop/composition):
a. project creation or reuse
b. network
c. image building
d. service accounts
e. notebook instances
and provide a parent a rad-lab environment that compose (a, b, c, d) and leave the management of e. to the root module?

Describe alternatives you've considered

While terraform supports object input variables, it sounds cumbersome and error prone to maintain a direct mapping between user-provided variable and notebooks_instance to allow fine grained customization.

Related feature requests

This could also allow easier integration in other terraform based project like https://github.com/GoogleCloudPlatform/hpc-toolkit.

Priority
Low

Labels
Notebooks, Silicon

@proppy proppy added the enhancement New feature or request label Nov 15, 2022
@github-actions
Copy link
Contributor

Thank you for raising the request! RAD Lab admins have been notified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant