Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of non existent columns quietly ignored #1370

Open
sundar-mudupalli-work opened this issue Dec 11, 2024 · 0 comments
Open

Validation of non existent columns quietly ignored #1370

sundar-mudupalli-work opened this issue Dec 11, 2024 · 0 comments
Labels
type: feature request 'Nice-to-have' improvement, new feature or different behavior or design.

Comments

@sundar-mudupalli-work
Copy link
Collaborator

Hi,

When users request validation of non existent columns, the validation for that column is quietly ignored.

  1. DVT should minimally log a WARNING - so customers know the the validation column they requested does not exist. Logging an error could break current validations.

To demonstrate try this command data-validation validate column -sc oracle21 -tc postgres -count='col_baa' tbls=pso_data_validator.dvt_core_types=pso_data_validator.dvt_core_types or this data-validation validate row -sc oracle21 -tc postgres -hash='col_date,col_baa' -pk=id -tbls=pso_data_validator.dvt_core_types=pso_data_validator.dvt_core_types

  1. This may require updates to our test suites - since they don't expect the warning.

Thanks.

Sundar Mudupalli

@helensilva14 helensilva14 added the type: feature request 'Nice-to-have' improvement, new feature or different behavior or design. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request 'Nice-to-have' improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants