Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose option should probably be deprecated #1363

Open
sundar-mudupalli-work opened this issue Dec 3, 2024 · 0 comments
Open

Verbose option should probably be deprecated #1363

sundar-mudupalli-work opened this issue Dec 3, 2024 · 0 comments
Labels
priority: p3 Lowest priority. This can be something deprioritized or not time sensitive. type: cleanup An internal cleanup or hygiene concern.

Comments

@sundar-mudupalli-work
Copy link
Collaborator

Hi,

Data Validation Tool has a very good way of printing information to troubleshoot and debug and that is by using -ll=DEBUG. We also have the verbose option -v. It is sparingly used and is used primarily to print the queries. I suggest we deprecate this option and move all such usage to logging.debug. The code has some strange structure as follows:

        if self.verbose:
            logging.info(target_config)

If the user specified verbose -v, then the information is logged at the info level, otherwise it is not. Best to replace these with logging.debug and get rid of the -v or quietly change it to -ll=DEBUG under the covers.

Sundar Mudupalli

@helensilva14 helensilva14 added type: cleanup An internal cleanup or hygiene concern. priority: p3 Lowest priority. This can be something deprioritized or not time sensitive. labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Lowest priority. This can be something deprioritized or not time sensitive. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

2 participants