Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL column validation on 38 digit number fails #1360

Open
nj1973 opened this issue Nov 29, 2024 · 1 comment
Open

PostgreSQL column validation on 38 digit number fails #1360

nj1973 opened this issue Nov 29, 2024 · 1 comment
Labels
priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@nj1973
Copy link
Contributor

nj1973 commented Nov 29, 2024

Test case using our existing integration test table:

data-validation validate column -sc ora -tc pg \
  --tables-list=pso_data_validator.dvt_large_decimals \
  --count="*" --min="*" --max="*" --sum="*" \
  --filter-status=fail
╒═══════════════════╤═══════════════════╤═══════════════════════════════════════╤══════════════════════╤════════════════════════════════════════╤═════════════════════════════════════════╤══════════════════╤═════════════════════╤══════════════════════════════════════╕
│ validation_name   │ validation_type   │ source_table_name                     │ source_column_name   │                       source_agg_value │ target_agg_value                        │   pct_difference │ validation_status   │ run_id                               │
╞═══════════════════╪═══════════════════╪═══════════════════════════════════════╪══════════════════════╪════════════════════════════════════════╪═════════════════════════════════════════╪══════════════════╪═════════════════════╪══════════════════════════════════════╡
│ sum__col_dec_38   │ Column            │ pso_data_validator.dvt_large_decimals │ col_dec_38           │ 67037036703703703670370370367037037034 │ ####################################.## │              nan │ fail                │ 7aebf793-04b8-4443-958d-b53136c16fad │
╘═══════════════════╧═══════════════════╧═══════════════════════════════════════╧══════════════════════╧════════════════════════════════════════╧═════════════════════════════════════════╧══════════════════╧═════════════════════╧══════════════════════════════════════╛

Notice the overflowing value returned from PostgreSQL.

This also highlights that we are missing column validation tests for this test table.

@helensilva14 helensilva14 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) labels Dec 2, 2024
@helensilva14
Copy link
Collaborator

I labeled this issue as p2 for now, but @nj1973 please update if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Medium priority. Fix may not be included in next release (e.g. minor documentation, cleanup) type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants