Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure consistent time zones for TIME fields in row hash validations #1301

Open
karcot1 opened this issue Oct 21, 2024 · 2 comments
Open

Ensure consistent time zones for TIME fields in row hash validations #1301

karcot1 opened this issue Oct 21, 2024 · 2 comments
Labels
priority: p1 High priority. Fix may be included in the next release. type: question Request for information or clarification. Not an issue.

Comments

@karcot1
Copy link

karcot1 commented Oct 21, 2024

DVT assumes BQ time fields are in UTC, and only casts time on the Teradata end to GMT to account for this offset. With our customer, we have found this is not always the case. For example when data is loaded to BQ from external source systems, we are seeing data in BQ with EST time zones.

As a result, casting to GMT only on the TD side hashes creates instances where two identical time fields fail a row hash and two very different time values can potentially succeed.

This also creates an inconsistency between the row hash and compare fields validation, as comp fields will pass validation without modifying the timezones.

Is there any way to ensure the casting to a timezone is consistent between both TD and BQ, to avoid false positive/negative validations in the row hash?

Thanks very much!

@sundar-mudupalli-work
Copy link
Collaborator

Kash,

You are correct. BQ refers to default timezone - which the documentation says is normally UTC. Customers can set the default timezone for their project/organization to be something different. The documentation says we can set the timezone of a query/connection to a specific value without providing a straightforward code sample. Investigating.

Sundar Mudupalli

@nj1973
Copy link
Contributor

nj1973 commented Oct 22, 2024

We had this previously for BigQuery timestamps: https://github.com/GoogleCloudPlatform/professional-services-data-validator/pull/1174/files

Strange that the fix did not work for time data but might be worth investigating.

@helensilva14 helensilva14 added type: question Request for information or clarification. Not an issue. priority: p1 High priority. Fix may be included in the next release. labels Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 High priority. Fix may be included in the next release. type: question Request for information or clarification. Not an issue.
Projects
Status: No status
Development

No branches or pull requests

4 participants