Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Developer Connect Terraform to include BBC and BBDC #12608

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

ihnarayanan
Copy link

fixes hashicorp/terraform-provider-google/issues/20749

developerconnect: added `bitbucketCloudConfig` and `bitbucketDataCenterConfig` fields to `google_developer_connect_connection` resource

@ihnarayanan ihnarayanan changed the title Dc bb Expand Developer Connect Terraform to include BBC and BBDC Dec 18, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 6428 insertions(+), 80 deletions(-))
google-beta provider: Diff ( 7 files changed, 4533 insertions(+), 403 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 769 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 48 files changed, 1465 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  etag = # value needed
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 21
Passed tests: 1
Skipped tests: 0
Affected tests: 20

Click here to see the affected service packages
  • developerconnect
#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 20 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDeveloperConnectConnection_BbdcPrivConnection
  • TestAccDeveloperConnectConnection_GhePrivConnection
  • TestAccDeveloperConnectConnection_GlePrivConnection
  • TestAccDeveloperConnectConnection_developerConnectConnectionBbdcExample
  • TestAccDeveloperConnectConnection_developerConnectConnectionBitbucketCloudExample
  • TestAccDeveloperConnectConnection_developerConnectConnectionBitbucketCloudUpdate
  • TestAccDeveloperConnectConnection_developerConnectConnectionBitbucketDataCenterUpdate
  • TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample
  • TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseUpdate
  • TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample
  • TestAccDeveloperConnectConnection_developerConnectConnectionGithubUpdate
  • TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample
  • TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseUpdate
  • TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample
  • TestAccDeveloperConnectConnection_developerConnectConnectionGitlabUpdate
  • TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkBbdcExample
  • TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkBitbucketCloudExample
  • TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample
  • TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample
  • TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 18 files changed, 6428 insertions(+), 80 deletions(-))
google-beta provider: Diff ( 7 files changed, 4533 insertions(+), 403 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 769 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 48 files changed, 1465 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_developer_connect_connection (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_developer_connect_connection" "primary" {
  etag = # value needed
  installation_state {
    action_uri = # value needed
    message    = # value needed
  }
}

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDeveloperConnectConnection_GhePrivConnection [Debug log]
TestAccDeveloperConnectConnection_GlePrivConnection [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseExample [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubEnterpriseUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubExample [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGithubUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseExample [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabEnterpriseUpdate [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabExample [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionGitlabUpdate [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubEnterpriseExample [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabEnterpriseExample [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGitlabExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_BbdcPrivConnection [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionBbdcExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionBitbucketCloudExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionBitbucketCloudUpdate [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionBitbucketDataCenterUpdate [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkBbdcExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkBitbucketCloudExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 21
Passed tests: 14
Skipped tests: 0
Affected tests: 7

Click here to see the affected service packages
  • developerconnect
#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkGithubExample

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDeveloperConnectConnection_BbdcPrivConnection
  • TestAccDeveloperConnectConnection_developerConnectConnectionBbdcExample
  • TestAccDeveloperConnectConnection_developerConnectConnectionBitbucketCloudExample
  • TestAccDeveloperConnectConnection_developerConnectConnectionBitbucketCloudUpdate
  • TestAccDeveloperConnectConnection_developerConnectConnectionBitbucketDataCenterUpdate
  • TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkBbdcExample
  • TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkBitbucketCloudExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDeveloperConnectConnection_BbdcPrivConnection [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionBbdcExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionBitbucketCloudExample [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionBitbucketCloudUpdate [Error message] [Debug log]
TestAccDeveloperConnectConnection_developerConnectConnectionBitbucketDataCenterUpdate [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkBbdcExample [Error message] [Debug log]
TestAccDeveloperConnectGitRepositoryLink_developerConnectGitRepositoryLinkBitbucketCloudExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Bitbucket Cloud and Bitbucket Data Center to google_developer_connect_connection
2 participants