Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the fields to google_compute_network_peering_routes_config #11573

Open
jeffling-google opened this issue Apr 24, 2022 · 5 comments · May be fixed by GoogleCloudPlatform/magic-modules#12581
Open

Add the fields to google_compute_network_peering_routes_config #11573

jeffling-google opened this issue Apr 24, 2022 · 5 comments · May be fixed by GoogleCloudPlatform/magic-modules#12581
Assignees
@benjamin-maynard
Labels
enhancement forward/linked service/compute-network-peering size/s
Milestone
Goals

Comments

@jeffling-google
Copy link

jeffling-google commented Apr 24, 2022 •
edited by modular-magician
Loading

In resource google_compute_network_peering, there are two fields:
export_subnet_routes_with_public_ip
and
import_subnet_routes_with_public_ip

But they are not available in the resource google_compute_network_peering_routes_config.

Affected Resource(s)

  • google_compute_network_peering_routes_config

b/374161637
@rileykarson rileykarson added this to the Goals milestone Apr 25, 2022
@maguro
Copy link

maguro commented Nov 5, 2022

jfyi, this is needed to transliterate the article "Accessing private Google Kubernetes Engine clusters with Cloud Build private pools" into Terraform.

@AarshDhokai
Copy link
Contributor

AarshDhokai commented Dec 26, 2022 •
edited
Loading

b/263711721

@AarshDhokai AarshDhokai mentioned this issue Dec 27, 2022
Closed
5 tasks
@github-actions github-actions bot added forward/review In review; remove label to forward service/compute-network-peering labels Nov 11, 2023
@benjamin-maynard
Copy link

b/353425623

@ggtisc ggtisc self-assigned this Aug 15, 2024
@ggtisc
Copy link
Collaborator

ggtisc commented Aug 15, 2024

Currently both arguments are available and working:

@ggtisc ggtisc closed this as completed Aug 15, 2024
@benjamin-maynard
Copy link

benjamin-maynard commented Aug 15, 2024 •
edited
Loading

@ggtisc This should be kept open. The request is to include this in the compute_network_peering_routes_config resource.

There are scenarios where the peering configuration is created by Google (such as Private Services Access) - but there is a need to adjust the routes config.

@roaks3 roaks3 reopened this Aug 19, 2024
@benjamin-maynard benjamin-maynard mentioned this issue Aug 19, 2024
Closed
@roaks3 roaks3 assigned benjamin-maynard and unassigned ggtisc Aug 20, 2024
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Aug 29, 2024
@modular-magician
container: Add node_kublet_config support for autopilot clusters (h…
b2b9868 
…ashicorp#11573)

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

[upstream:bba168c53a1cd6c79cc2799da4a9878ca97778fb]

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit that referenced this issue Aug 29, 2024
@modular-magician
container: Add node_kublet_config support for autopilot clusters (#…
bcac3fa 
…11573) (#19320)

[upstream:bba168c53a1cd6c79cc2799da4a9878ca97778fb]

Signed-off-by: Modular Magician <[email protected]>
c2thorn pushed a commit that referenced this issue Sep 5, 2024
@modular-magician @c2thorn
container: Add node_kublet_config support for autopilot clusters (#…
e754113 
…11573) (#19320)

[upstream:bba168c53a1cd6c79cc2799da4a9878ca97778fb]

Signed-off-by: Modular Magician <[email protected]>
@melinath melinath removed the forward/review In review; remove label to forward label Oct 17, 2024
@brcabrera brcabrera linked a pull request Dec 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamin-maynard benjamin-maynard

Labels
enhancement forward/linked service/compute-network-peering size/s
Projects
None yet
Milestone
Goals
9 participants
@maguro @melinath @rileykarson @roaks3 @modular-magician @benjamin-maynard @jeffling-google @AarshDhokai @ggtisc