Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker.tag.long usage #123

Open
jmcc0nn3ll opened this issue Jan 25, 2017 · 3 comments
Open

docker.tag.long usage #123

jmcc0nn3ll opened this issue Jan 25, 2017 · 3 comments

Comments

@jmcc0nn3ll
Copy link
Contributor

Currently the jetty9 module tags with a long timestamp format and this pollutes a local docker repository.

We use it for test behavior though so we still need it, but it would be good to perhaps clean this up after running tests.

Is there a reason to have tag.short and tag.long outside of the test usage and does smoking the tag.long at the end of the build raise any red flags?

@meltsufin
Copy link
Member

I do agree that we should probably provide the ability to clean up the created images in the local repo, but I don't think it's sufficient to remove the long tag because the image will still remain and keep taking up space. So, we would want to force delete the whole image with all of its tags.

I think the more appropriate place for this cleanup is to bind a goal to the "clean" phase, but then there's the challenge of figuring out which images were created by the project.

@jmcc0nn3ll
Copy link
Contributor Author

jmcc0nn3ll commented Jan 26, 2017

well, can just have an execution bound to clean that operates a bit like your bash magic one piped through xargs to remove based on a tag expression

I suppose we could tag for testing specifically and then just clean those tags, ex. {docker.tag.short}-test.

@meltsufin
Copy link
Member

Yes, I guess we can just add an additional tag like jetty:{docker.tag.long}-test, and then delete all of the images that match that pattern in clean phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants