Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CloudEventWithCallback function signature to functions.cloudEvent() #633

Open
thekumar opened this issue Sep 10, 2024 · 0 comments · May be fixed by #631
Open

Add CloudEventWithCallback function signature to functions.cloudEvent() #633

thekumar opened this issue Sep 10, 2024 · 0 comments · May be fixed by #631

Comments

@thekumar
Copy link

The typescript typings for functions.cloudEvent() only include the CloudEvent function signature and not the CloudEventWithCallback signature, which allows for surfacing errors and nacking message for retryability.

I have already submitted a fix PR #631 for review, and hopefully this issue is useful for tracking reviewer assignments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix typings for functions.cloudEvent to include callback. thekumar/functions-framework-nodejs
1 participant
@thekumar