Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-lite has not been added as maven module #23

Open
lachlan-roberts opened this issue May 29, 2023 · 2 comments
Open

runtime-lite has not been added as maven module #23

lachlan-roberts opened this issue May 29, 2023 · 2 comments
Assignees

Comments

@lachlan-roberts
Copy link
Collaborator

runtime-lite has not been added as a maven module and so it won't build with the rest of the project.

It needs an entry in the <modules> section of runtime/pom.xml, but when added it gives some compile errors

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project runtime-lite: Compilation failure: Compilation failure: 
[ERROR] appengine-java-standard/runtime/lite/src/test/java/com/google/appengine/runtime/lite/RequestManagerTest.java:[295,63] cannot find symbol
[ERROR]   symbol:   method getGeneratedRegistry()
[ERROR]   location: class com.google.protobuf.ExtensionRegistry
[ERROR] appengine-java-standard/runtime/lite/src/test/java/com/google/appengine/runtime/lite/RequestManagerTest.java:[334,63] cannot find symbol
[ERROR]   symbol:   method getGeneratedRegistry()
[ERROR]   location: class com.google.protobuf.ExtensionRegistry
[ERROR] -> [Help 1]
@lachlan-roberts
Copy link
Collaborator Author

I don't think this was actually resolved.

Although it does look like the compile errors were addressed in that commit.

@lachlan-roberts lachlan-roberts self-assigned this Sep 18, 2024
@ludoch
Copy link
Collaborator

ludoch commented Sep 18, 2024

Be careful with this new module as the way it can be used publicly is tricky (completely different boot process, no app class loader, no jsp support, no static files, etc, and expectation of a big fatjar at the end with the app to execute the app). Before pushing to maven central, we need to think

srinjoyray pushed a commit that referenced this issue Nov 12, 2024
Fix #23

PiperOrigin-RevId: 539994818
Change-Id: Ic6eb62982532f534b6cb73f366b06d3668105c73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants