New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Use Java 17 for Dataflow Templates #2051

Open

liferoad opened this issue Dec 5, 2024 · 1 comment

Assignees

Labels

Contributor

liferoad commented Dec 5, 2024

Related Template(s)

All templates

What feature(s) are you requesting?

#2050 indicates most of tests can run fine with Java 17. Maybe we can move to Java 17 for all templates.

liferoad added addition p2 needs triage labels

Contributor Author

liferoad commented Dec 5, 2024

Target version needs to be updated everywhere to 17, examples:

DataflowTemplates/pom.xml

Line 34 in ff14f97

<java.version>11</java.version>

DataflowTemplates/plugins/core-plugin/pom.xml

Line 35 in ff14f97

<maven.compiler.source>11</maven.compiler.source>

DataflowTemplates/v2/pom.xml

Line 421 in ff14f97

<maxJdkVersion>11</maxJdkVersion>
Containers need to be updated to java17 (example:

DataflowTemplates/plugins/templates-maven-plugin/src/main/java/com/google/cloud/teleport/plugin/maven/TemplatesReleaseFinishMojo.java

Line 88 in ff14f97

"gcr.io/dataflow-templates-base/java11-template-launcher-base-distroless:latest",

).

liferoad self-assigned this

liferoad removed the needs triage label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment