Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Custom Permission Creation UI #26

Open
jamesmarlowe opened this issue Apr 8, 2017 · 1 comment
Open

Build Custom Permission Creation UI #26

jamesmarlowe opened this issue Apr 8, 2017 · 1 comment

Comments

@jamesmarlowe
Copy link
Contributor

jamesmarlowe commented Apr 8, 2017

UI should look like this: https://docs.google.com/a/juristat.com/spreadsheets/d/1tUIzS6HTq0_TpZWaOgvITNIf81ps3wUV4mbmE7FROAM/edit?usp=sharing

Each column name should represent a data point we collect. There should be some default permission types we create to begin with (e.g. full access, no access). There should be a legend that describes what green and red cells mean. Finally each cell should be toggle-able between red and green. Green meaning share if rule is met, and red is never share for that custom rule.

Users should also be able to create new custom permissions which will add a row to the table. The custom permission name takes a string input, and any admin user should be able to change the name (and it should update throughout the app if the name is changed).

If the user clicks "Edit" text in the Custom Rules column. It will pop up a custom rule generator modal that mirrors topopps (screenshot attached). In that modal users should be able to create a custom rule made up of a data point (e.g. column name), operator (e.g. >=) and a value. For example, if a user wanted to only share data for Veteran seniors then they would create a custom rule with the following info:

Data point: Age; Operator: >=; Value: 65
Data point: Veterans; Operator: =; Value: TRUE

Note that different operators will appear and operators will behave differently based on the variable type of the data point. For example, in the above, the data point Age takes an Int variable and thus the operators that appears should be >, >=, =, <=, < (at this point we can't let users select a range between two integers, but we will build that functionality eventually). Conversely, the Veteran's data point is a boolean so the only operator is =, then the values can be TRUE or FALSE.

Possible Operators:
Integers: >, >=, =, <=, <
Strings: = OR =/= which works as is.match(), does.not.match()
Booleans: =

@jamesmarlowe jamesmarlowe self-assigned this Apr 8, 2017
@DCalliet DCalliet self-assigned this Apr 9, 2017
@drew-winship drew-winship changed the title Allow admin users to set roles for other users Allow admin users to set data sharing permission roles for all data controlled by their org May 7, 2017
@drew-winship drew-winship changed the title Allow admin users to set data sharing permission roles for all data controlled by their org Build Custom Permission Creation UI May 29, 2017
@drew-winship
Copy link

screen shot 2017-05-29 at 1 50 48 pm

screen shot 2017-05-29 at 1 45 57 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants