Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Dashboard - Improve search functionality (title) #368

Closed
WhyldWanderer opened this issue Feb 21, 2022 · 8 comments
Closed

Admin Dashboard - Improve search functionality (title) #368

WhyldWanderer opened this issue Feb 21, 2022 · 8 comments

Comments

@WhyldWanderer
Copy link

As an admin, It would be very useful to be able to search for projects by a title that may not be exact.

As of now if I search for a project it is case-sensitive and I am required to search for the 'exact' title, I would love to have more flexibility within the search.

@CarlosQ96
Copy link
Collaborator

Underestimated this task, seems I gotta investigate a bit more, Adminbro not that flexible.

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Jun 26, 2024
@divine-comedian divine-comedian moved this from New Issues to Done in All-Devs Jun 26, 2024
@divine-comedian divine-comedian moved this from Done to Product Backlog in All-Devs Jun 26, 2024
@RamRamez
Copy link
Collaborator

We did some improvements on search functionality and I think we can close this. @WhyldWanderer WDYT?

@WhyldWanderer
Copy link
Author

Thanks Ramin!

I think its working better than when I made the issue.

However, its still strange to me that when I search "codex" or "CODEX" on the projects page, I do not get this project at all:
https://giveth.io/project/codex

It seems that the "$" sign keeps it from being searchable somehow. It seems that this would be something that we could account for? I think its disheartening for project owners when they search their project on the page and don't see it show up on the list.

I will keep an eye out as Im searching projects etc for use cases such as this and post any here that I find in the coming days in case that might be helpful.

@RamRamez
Copy link
Collaborator

@Reshzera Can you please take this?

@Reshzera
Copy link
Contributor

@RamRamez Sure

@Reshzera Reshzera moved this from Product Backlog to In Progress in All-Devs Jul 25, 2024
@WhyldWanderer
Copy link
Author

WhyldWanderer commented Jul 29, 2024

Im sorry @RamRamez.. I was out of my element. There are 2 issues involving search functionality and I thought I was in the other issue. Apologies!

I would hate to put too much dev resources into this issue as it is really just a nice to have.

If Carlos doesnt think its a good idea, I trust his knowledge of the issue.
I think we can close this one

@Reshzera
Copy link
Contributor

@RamRamez @WhyldWanderer I couldn't find a solution to this issue, because I couldn't find some way to change the built-in filters on AdminJs.

@Reshzera Reshzera moved this from In Progress to Product Backlog in All-Devs Jul 30, 2024
@Reshzera Reshzera removed their assignment Aug 5, 2024
@CarlosQ96 CarlosQ96 moved this from Product Backlog to In Progress in All-Devs Oct 29, 2024
@CarlosQ96
Copy link
Collaborator

CarlosQ96 commented Oct 30, 2024

Upon further investigation this is simply not posible on adminjs. Not even overriding filters. It basically only allows adding custom html dropdowns, but not modify queries.
There is a 2023 PR on Adminjs main repo that fixes this issue, but it has not been merged to adminjs Master.
I don't think we should spend more time on this.

@WhyldWanderer Ill close the issue as it's imposible without overwriting database adapters from the framework (not recommended as we would need to fork). We can hope they merge the PR to Adminjs Repo sometime this year.

Refer to this conversations for adminjs:
SoftwareBrothers/adminjs-sequelizejs#107

We can reopen the issue, if they merge Postgresql PR, so all we would need to do is to update the framework.

@github-project-automation github-project-automation bot moved this from In Progress to Done in All-Devs Oct 30, 2024
@CarlosQ96 CarlosQ96 moved this from Done to Icebox in All-Devs Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Icebox
Development

No branches or pull requests

6 participants