Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable or customize the bypass message #929

Open
alexku7 opened this issue Jul 2, 2024 · 3 comments
Open

Disable or customize the bypass message #929

alexku7 opened this issue Jul 2, 2024 · 3 comments
Labels
status:new This issue needs to be reviewed type:feature Feature request

Comments

@alexku7
Copy link

alexku7 commented Jul 2, 2024

Currently if a secret has been discovered during the pre-push or pre-commit hook, the cli prints a bypass message suggestion to use --no-verify flag.

The problem that people see it and without thinking too much just run it and create an incident and potential secret leakage.

We would like to disable this message ot at lease to change it. In our opinion the message just engages people to bypass the hook and upload secrets to git by mistake.

@alexku7 alexku7 added status:new This issue needs to be reviewed type:feature Feature request labels Jul 2, 2024
@mathieubellon
Copy link
Collaborator

mathieubellon commented Jul 2, 2024

Hello @alexku7 !
We have identified this problem and are currently working on a feature allowing users to broadcast their own custom message at various steps (pre-commit, pre-push, etc ..)
Here is the PR but keep in mind that this feature is not CLI only so it will available when we will also update the API

@alexku7
Copy link
Author

alexku7 commented Jul 2, 2024

Hello @alexku7 ! We have identified this problem and are currently working on a feature allowing users to broadcast their own custom message at various steps (pre-commit, pre-push, etc ..) Here is the PR but keep in mind that this feature is not CLI only so it will available when we will also update the API

Thank you @mathieubellon
If I understand correctly the PR allows to customize the remediation message but our problem is also in BYPASS_MESSAGE :(

The BYPASS_MESSAGE engages people to push or commit with --no-verify and it leads to too many mistakes :(

@mathieubellon
Copy link
Collaborator

mathieubellon commented Jul 2, 2024

The custom message will override everything, including the bypass message.
Users will be free to customize the complete message area (remediation and bypass)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:new This issue needs to be reviewed type:feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants