Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: nos2x/alby/nip07 support #51

Open
3 tasks
Giszmo opened this issue Nov 2, 2022 · 1 comment
Open
3 tasks

Feature: nos2x/alby/nip07 support #51

Giszmo opened this issue Nov 2, 2022 · 1 comment
Assignees
Milestone

Comments

@Giszmo
Copy link
Owner

Giszmo commented Nov 2, 2022

Many more advanced users dread giving many apps their private keys, so they use nos2x or alby to sign events or decrypt messages.

https://github.com/nostr-protocol/nips/blob/master/07.md

  • Check if Alby supports DMs and works for Chrome and FF
  • If not, check the difference between nos2x for FF and for Chrome
  • Implement window.nostr.signEvent() if pubkey is window.nostr.getPublicKey()

Implementation of support for account addition from window.nostr.getPublicKey() "Your nostr extension has an account you haven't added yet. Do you want to use with Nostroid?". Is low priority.

@Giszmo Giszmo added this to the MVP + 1 milestone Nov 2, 2022
@Giszmo
Copy link
Owner Author

Giszmo commented Dec 16, 2022

An XSS vulnerability in Anigma that could have resulted in the leak of most users' keys just bumped this issue from MVP+1 to MVP. It should be easy to implement. Beware the nos2x working differently on FF and Chrome. Alby might still not support DMs ...

@Giszmo Giszmo modified the milestones: MVP + 1, MVP Dec 16, 2022
@louishuddleston louishuddleston self-assigned this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants