From ce4355033fecd38b0aba17ced674aa595c804e37 Mon Sep 17 00:00:00 2001 From: hmerrettICHK <74997253+hmerrettICHK@users.noreply.github.com> Date: Mon, 3 Oct 2022 08:48:50 +0800 Subject: [PATCH] v1.5.11 Co-authored-by: Wren Merrett <> Co-authored-by: Sandra Kuipers --- ATL/CHANGEDB.php | 5 +++++ ATL/CHANGELOG.txt | 5 +++++ ATL/atl_manage_addProcess.php | 10 +++++----- ATL/atl_manage_deleteProcess.php | 4 ++-- ATL/atl_manage_editProcess.php | 10 +++++----- ATL/atl_write_dataProcess.php | 4 ++-- ATL/manifest.php | 2 +- ATL/version.php | 2 +- 8 files changed, 26 insertions(+), 16 deletions(-) diff --git a/ATL/CHANGEDB.php b/ATL/CHANGEDB.php index c229fc6..243c190 100644 --- a/ATL/CHANGEDB.php +++ b/ATL/CHANGEDB.php @@ -181,3 +181,8 @@ ++$count; $sql[$count][0] = '1.5.10'; $sql[$count][1] = ''; + +//v1.5.11 +++$count; +$sql[$count][0] = '1.5.11'; +$sql[$count][1] = ''; \ No newline at end of file diff --git a/ATL/CHANGELOG.txt b/ATL/CHANGELOG.txt index c598227..4db1c0c 100644 --- a/ATL/CHANGELOG.txt +++ b/ATL/CHANGELOG.txt @@ -1,5 +1,10 @@ CHANGELOG ========= +v1.5.11 +------- +Refactoring null coalesce + +======= v1.5.10 ------- Fixed visualization showing data that has not gone live diff --git a/ATL/atl_manage_addProcess.php b/ATL/atl_manage_addProcess.php index 829bad0..0015ec0 100644 --- a/ATL/atl_manage_addProcess.php +++ b/ATL/atl_manage_addProcess.php @@ -21,7 +21,7 @@ include '../../gibbon.php'; -$gibbonCourseClassID = $_GET['gibbonCourseClassID']; +$gibbonCourseClassID = $_GET['gibbonCourseClassID'] ?? ''; $URL = $session->get('absoluteURL').'/index.php?q=/modules/'.getModuleName($_GET['address'])."/atl_manage_add.php&gibbonCourseClassID=$gibbonCourseClassID"; if (isActionAccessible($guid, $connection2, '/modules/ATL/atl_manage_add.php') == false) { @@ -40,10 +40,10 @@ $gibbonCourseClassIDMulti = $_POST['gibbonCourseClassIDMulti']; $gibbonCourseClassIDMulti = array_unique($gibbonCourseClassIDMulti); } - $name = $_POST['name']; - $description = $_POST['description']; - $gibbonRubricID = $_POST['gibbonRubricID']; - $completeDate = $_POST['completeDate']; + $name = $_POST['name'] ?? ''; + $description = $_POST['description'] ?? ''; + $gibbonRubricID = $_POST['gibbonRubricID'] ?? ''; + $completeDate = $_POST['completeDate'] ?? ''; if ($completeDate == '') { $completeDate = null; $complete = 'N'; diff --git a/ATL/atl_manage_deleteProcess.php b/ATL/atl_manage_deleteProcess.php index e441ead..b6dca6d 100644 --- a/ATL/atl_manage_deleteProcess.php +++ b/ATL/atl_manage_deleteProcess.php @@ -20,8 +20,8 @@ include '../../gibbon.php'; -$gibbonCourseClassID = $_POST['gibbonCourseClassID']; -$atlColumnID = $_GET['atlColumnID']; +$gibbonCourseClassID = $_POST['gibbonCourseClassID'] ?? ''; +$atlColumnID = $_GET['atlColumnID'] ?? ''; $URL = $session->get('absoluteURL').'/index.php?q=/modules/'.getModuleName($_POST['address'])."/atl_manage_delete.php&atlColumnID=$atlColumnID&gibbonCourseClassID=$gibbonCourseClassID"; $URLDelete = $session->get('absoluteURL').'/index.php?q=/modules/'.getModuleName($_POST['address'])."/atl_manage.php&gibbonCourseClassID=$gibbonCourseClassID"; diff --git a/ATL/atl_manage_editProcess.php b/ATL/atl_manage_editProcess.php index 316e872..da63171 100644 --- a/ATL/atl_manage_editProcess.php +++ b/ATL/atl_manage_editProcess.php @@ -21,8 +21,8 @@ include '../../gibbon.php'; -$gibbonCourseClassID = $_GET['gibbonCourseClassID']; -$atlColumnID = $_GET['atlColumnID']; +$gibbonCourseClassID = $_GET['gibbonCourseClassID'] ?? ''; +$atlColumnID = $_GET['atlColumnID'] ?? ''; $URL = $session->get('absoluteURL').'/index.php?q=/modules/'.getModuleName($_GET['address'])."/atl_manage_edit.php&atlColumnID=$atlColumnID&gibbonCourseClassID=$gibbonCourseClassID"; if (isActionAccessible($guid, $connection2, '/modules/ATL/atl_manage_edit.php') == false) { @@ -67,9 +67,9 @@ $row = $result->fetch(); //Validate Inputs - $name = $_POST['name']; - $description = $_POST['description']; - $gibbonRubricID = $_POST['gibbonRubricID']; + $name = $_POST['name'] ?? ''; + $description = $_POST['description'] ?? ''; + $gibbonRubricID = $_POST['gibbonRubricID'] ?? ''; $completeDate = $_POST['completeDate']; if ($completeDate == '') { $completeDate = null; diff --git a/ATL/atl_write_dataProcess.php b/ATL/atl_write_dataProcess.php index 7eb6d6b..34e25d1 100644 --- a/ATL/atl_write_dataProcess.php +++ b/ATL/atl_write_dataProcess.php @@ -21,8 +21,8 @@ include '../../gibbon.php'; -$gibbonCourseClassID = $_GET['gibbonCourseClassID']; -$atlColumnID = $_GET['atlColumnID']; +$gibbonCourseClassID = $_GET['gibbonCourseClassID'] ?? ''; +$atlColumnID = $_GET['atlColumnID'] ?? ''; $URL = $session->get('absoluteURL').'/index.php?q=/modules/'.getModuleName($_GET['address'])."/atl_write_data.php&atlColumnID=$atlColumnID&gibbonCourseClassID=$gibbonCourseClassID"; if (isActionAccessible($guid, $connection2, '/modules/ATL/atl_write_data.php') == false) { diff --git a/ATL/manifest.php b/ATL/manifest.php index bbb672d..043f608 100644 --- a/ATL/manifest.php +++ b/ATL/manifest.php @@ -25,7 +25,7 @@ $entryURL = 'atl_write.php'; $type = 'Additional'; $category = 'Assess'; -$version = '1.5.10'; +$version = '1.5.11'; $author = 'Ross Parker'; $url = 'http://rossparker.org'; diff --git a/ATL/version.php b/ATL/version.php index e41cbc5..48e8eb1 100644 --- a/ATL/version.php +++ b/ATL/version.php @@ -20,5 +20,5 @@ /** * Sets version information. */ -$moduleVersion = '1.5.10'; +$moduleVersion = '1.5.11'; $coreVersion = '23.0.00';