Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce cropping options #364

Open
adeane-ga opened this issue Oct 18, 2021 · 2 comments
Open

Reduce cropping options #364

adeane-ga opened this issue Oct 18, 2021 · 2 comments
Labels
enhancement

Comments

@adeane-ga
Copy link
Contributor

Simple Change to clarify usage
Currently PyRate has 4 options to crop, would be better if we reduce to 2 because the others are redundant and confusing.

Current Options:
# ifgcropopt: 1 = minimum extent 2 = maximum extent 3 = crop 4 = no cropping

Proposed Change:
# ifgcropopt: 1 = crop 2 = no cropping
@mcgarth
Copy link
Contributor

mcgarth commented Oct 29, 2021

I agree with the proposed change, but I would suggest a binary-style switch:

# ifgcropopt: 0 = do not crop; 1 = crop

@adeane-ga
Copy link
Contributor Author

I agree with the proposed change, but I would suggest a binary-style switch:

# ifgcropopt: 0 = do not crop; 1 = crop

Yeah I agree, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcgarth @adeane-ga