Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Design Results Page Pt2 #2017

Open
fongcindy opened this issue Dec 19, 2024 · 3 comments
Open

QA Design Results Page Pt2 #2017

fongcindy opened this issue Dec 19, 2024 · 3 comments
Assignees
Labels
V1 Final V1 handoff work

Comments

@fongcindy
Copy link
Collaborator

Domain

design

Related Issue(s)

Design file

Text size:
The plain body text within the accordion results has mixed sizes, it all needs to be consistent and the same size of 16px. Currently it is 16px.
image
Expected:
image

"Close all" has been deleted from mobile
image

@ErnestoFernandezAlvarez for viz

Description

No response

@ErnestoFernandezAlvarez
Copy link
Collaborator

ErnestoFernandezAlvarez commented Dec 20, 2024

@fongcindy thanks for consolidating these into one ticket!

@scottqueen-bixal I only found discrepancy on body text size on the accordion cards. All plain text on mobile is 16px.
Hope this is an easy fix!
Here is an extra screenshot taken from the Style guide. You could see this on dev mode as well:

Screenshot 2024-12-20 at 11 10 33 AM

@scottqueen-bixal scottqueen-bixal added the V1 Final V1 handoff work label Dec 23, 2024
@scottqueen-bixal
Copy link
Collaborator

@fongcindy thanks for consolidating these into one ticket!

@scottqueen-bixal I only found discrepancy on body text size on the accordion cards. All plain text on mobile is 16px. Hope this is an easy fix! Here is an extra screenshot taken from the Style guide. You could see this on dev mode as well:

Screenshot 2024-12-20 at 11 10 33 AM

this is a little bit confusing to me just because the only plain text is in the paragraph which is already at 16px

can you confirm that what you are asking for is:

all headings, descriptions, paragraphs, etc. font size needs to be 16px?

@fongcindy
Copy link
Collaborator Author

@ErnestoFernandezAlvarez Do we also need the headings to be 16px in the accordions? please advise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V1 Final V1 handoff work
Projects
None yet
Development

No branches or pull requests

3 participants