Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rs create a single reusable two column #7602

Closed
wants to merge 3 commits into from
Closed

Rs create a single reusable two column #7602

wants to merge 3 commits into from

Conversation

RileySeaburg
Copy link
Member

@RileySeaburg RileySeaburg commented May 21, 2024 •
edited
Loading

Summary

Created a two column template. Closes #7581.

Preview

Link to Preview

Solution

I created a template called two-column.html

themes/digital.gov/layouts/_default/two-column.html

How To Test

  1. Click on events
  2. Go to most recent event USWDS May Call.
  3. Press F12 or open dev tools.
  4. Check the console for a message.

Dev Checklist

  • PR has correct labels
  • A11y testing (voice over testing, meets WCAG, run axe tools)
  • Code is formatted properly
  • Ensure all other templates get updated.
  • Remove console.log

@RileySeaburg RileySeaburg self-assigned this May 21, 2024
@RileySeaburg RileySeaburg linked an issue May 21, 2024 that may be closed by this pull request
Create a single reusable two column #7581
Open
@github-actions GitHub Actions
Copy link

🔍 Preview in Federalist

@RileySeaburg RileySeaburg added Dev: Template Logic Fixes and improvements associated with our static site generator Dev: frontend ideas and issues related to the presentation layer of the site labels May 21, 2024
@RileySeaburg
Copy link
Member Author

Closing for debugging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToniBonittoGSA ToniBonittoGSA Awaiting requested review from ToniBonittoGSA

@nick-mon1 nick-mon1 Awaiting requested review from nick-mon1

Assignees

@RileySeaburg RileySeaburg

Labels
Dev: frontend ideas and issues related to the presentation layer of the site Dev: Template Logic Fixes and improvements associated with our static site generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a single reusable two column
1 participant
@RileySeaburg